feat: add support for SharedArrayBuffer in TypedArray and TypedArrayOf#1731
Merged
legendecas merged 1 commit intoMay 24, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1731 +/- ##
==========================================
+ Coverage 63.65% 63.69% +0.03%
==========================================
Files 3 3
Lines 2058 2063 +5
Branches 729 730 +1
==========================================
+ Hits 1310 1314 +4
Misses 162 162
- Partials 586 587 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
KevinEady
force-pushed
the
support-sharedarraybuffer-in-typedarray
branch
from
3de1889 to
09557a9
Compare
legendecas
reviewed
May 22, 2026
| assert.ok(bAsValue instanceof SharedArrayBuffer); | ||
| assert.strictEqual(bAsValue, sab); | ||
| } catch (ex) { | ||
| if (ex.message === 'Invalid argument') { |
Member
There was a problem hiding this comment.
I think this error is only expected on binding.typedarray.createInt8TypedArrayFromSharedArrayBuffer. Could this try...catch scope be limited to this single call instead?
KevinEady
force-pushed
the
support-sharedarraybuffer-in-typedarray
branch
from
09557a9 to
b247aa8
Compare
legendecas
approved these changes
May 22, 2026
github-project-automation
Bot
moved this from In Progress
to Done
in Node-API Team Project
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for
SharedArrayBufferinTypedArrayandTypedArrayOf<T>.Fixes: #1730